Fix 4686 Use IDEA Project JDK first #4689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griffio
changed the title
griffio
changed the title
|
Is this still a draft? |
getAvailableJdk checks for project Jdk first, then for the most recent Jdk version and finally the internal Jdk that could be JAVA_HOME Fallback to JAVA_HOME may not be needed
griffio
force-pushed
the
fix-4686-idea-plugin
branch
from
f7496c2
to
2bd8190
Compare
dellisd
approved these changes
Oct 18, 2023
|
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
getAvailableJdk checks for project Jdk first, then for the most recent Jdk version and finally the internal Jdk that could be JAVA_HOME Fallback to JAVA_HOME may not be needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4686
🧪 Have tested locally with snapshot IDEA plugin against reproducibles (Spring Boot Plugin + JAVA_HOME JDK 11)
getAvailableJdk() checks for project JDK first, then for the most recent JDK version and finally the internal JDK that could be JAVA_HOME
Explicit fallback to JAVA_HOME may not be needed as getAvailableJdk() appears to do this anyway