Fix 4714 postgresql alter column nullability #4831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4714
π§ π ποΈ PR to try and fix
TableInterfaceGenerator
for PostgreSql DialectThe AlterColumn Mixin will set the QueryColumn to appropriate nullable flag and this can be read in
TableInterfaceGenerator
As we can't modify ColumnDefs, use the QueryColumn to override the not null/nullable type if it is true or false (normally the nullable property will be
null
so no impact)π¦Ί Migration Test case to show it works
Have tried locally with snapshot build πΈ
four fields - drop and set nullability on y, t - keep a, b the same as a control
1.sqm
2.sqm
After: