Fix postgresql alter table alter column #4868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches the correct table if there are more than one table in the migration Removes the null check as one table is expected to be available in the alter table clause
Shows that two tables can be migrated
AlecKazakova
approved these changes
Dec 4, 2023
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Fix multiple tables in migration Matches the correct table if there are more than one table in the migration Removes the null check as one table is expected to be available in the alter table clause * Tests include two tables Shows that two tables can be migrated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍔 🔨 This is to fix the case where more than one table was migrated - should have used first {...} not first()
🐘 Tested with a more complete example locally https://github.com/griffio/sqldelight-postgres-01