Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the type nullability in encapsulatingType #4882

Merged

Conversation

eygraber
Copy link
Contributor

@eygraber eygraber commented Dec 5, 2023

  • For preferKotlinType in the homogeneous types case, the first type is selected
  • For a function like coalesce that's not correct since any non null arg makes the return not nullable
  • The previous behavior is maintained by making the nullability parameter null (which is the default)

Fixes #4870

  - For preferKotlinType in the homogeneous types case, the first type is selected
  - For a function like coalesce that's not correct since any non null arg makes the return not nullable
  - The previous behavior is maintained by making the nullability parameter null (which is the default)
Copy link
Contributor

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@AlecKazakova AlecKazakova merged commit b2b93a2 into cashapp:master Dec 5, 2023
7 checks passed
@AlecKazakova
Copy link
Collaborator

thank you 🙏

@eygraber eygraber deleted the fix-type-resolution-null-handling branch December 5, 2023 20:06
hfhbd pushed a commit that referenced this pull request Apr 2, 2024
- For preferKotlinType in the homogeneous types case, the first type is selected
  - For a function like coalesce that's not correct since any non null arg makes the return not nullable
  - The previous behavior is maintained by making the nullability parameter null (which is the default)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COALESCE regression
3 participants