fixes 4897 sqlite alter table rename column #4899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griffio
force-pushed
the
fix-sqlite-alter-table-rename-column
branch
from
24b7519
to
0c108a5
Compare
AlterTableColumnAliasMixin AlterTableRenameColumnMixin implement as SqlColumnDef
Add alter-table-rename-column-sqlite Needs as sqlite doesn't use JDBCPreparedStatement so test cannot be shared with `alter-table-rename-column`
alter_table_rename_column is imported into sqlite_3_35 as the alter_table_rules are overridden and need to include the alter_table_rename_column rules as well. This appears to be cleaner than trying to reimplement alter_table_rename_column
Use singleOrNull as potentially if the columnName is renamed already the predicate may return null Therefore the annotation should be displayed as a compiler message "No column found to modify with name <columnName>"
griffio
force-pushed
the
fix-sqlite-alter-table-rename-column
branch
from
096b2a0
to
96fecb7
Compare
AlecKazakova
approved these changes
Jan 29, 2024
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* fixes for Sqlite alter column AlterTableColumnAliasMixin AlterTableRenameColumnMixin implement as SqlColumnDef * Add MigrationQueryTest Add alter-table-rename-column-sqlite Needs as sqlite doesn't use JDBCPreparedStatement so test cannot be shared with `alter-table-rename-column` * Add inherited alter_table_rename_column rule alter_table_rename_column is imported into sqlite_3_35 as the alter_table_rules are overridden and need to include the alter_table_rename_column rules as well. This appears to be cleaner than trying to reimplement alter_table_rename_column * Update AlterTableRenameColumnMixin Use singleOrNull as potentially if the columnName is renamed already the predicate may return null Therefore the annotation should be displayed as a compiler message "No column found to modify with name <columnName>"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4897
🚧 🦺 fixes for sqlite_3_25 -> sqlite_3_35
AlterTableColumnAliasMixinparse node as aSqlColumnNameAlterTableRenameColumnMixinextendsSqlColumnDefImplsqlite.bnfreplace{column_alias}withalter_table_column_aliasimplementsSqlColumnName🛸 It's possible to import the fixed
alter_table_rename_columnintosqlite_3_35fromsqlite_3_25👽 as
sqlite_3_35adds some more rules toalter_table_rulesthealter_table_rename_columnneeds to be re-added.🐄 It wasn't possible to re-implement the new changes to the rule
alter_table_rename_tableinsqlite_3_35 sqlite.bnfso the below is much cleaner.Maybe some other tests?