Add postgresql alter column default support for insert statement #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlecKazakova
approved these changes
Jan 29, 2024
add open class as we want to call the inherited hasDefaultValue()
We want a column_not_null_clause rule to read SET or DROP DEFAULT
hasDefaultValue implemented by checking for a DEFAULT has SET or DROP, otherwise call inherited hasDefaultValue InsertStmtValuesMixin in the compiler use the result of ColumnDefMixin.hasDefaultValue
|
🤕 After mergings - there is a test fixture failure - will look into this week |
auto-merge was automatically disabled
January 30, 2024 13:41
Head branch was pushed to by a user without write access
griffio
force-pushed
the
add-postgresql-alter-column-default
branch
from
363e1e4
to
190cfef
Compare
|
thanks for fixing 👍 |
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Allow ColumnDefMixin to be inherited add open class as we want to call the inherited hasDefaultValue() * Update PostgreSql.bnf We want a column_not_null_clause rule to read SET or DROP DEFAULT * AlterTableAlterColumnMixin to inherit ColumnDefMixin hasDefaultValue implemented by checking for a DEFAULT has SET or DROP, otherwise call inherited hasDefaultValue InsertStmtValuesMixin in the compiler use the result of ColumnDefMixin.hasDefaultValue * Fix test Rename to correct column name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 🍔 🧷 Adding this to enable SET or DROP DEFAULT in
ALTER COLUMNmigrations.This is implemented for use by
app.cash.sqldelight.core.lang.psi.InsertStmtValuesMixinto enable/disable the annotation messageCannot populate default values for columns ..., they must be specified in insert statement.hasDefaultValue