Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostgreSql alter sequence and drop sequence #4920

Merged

Conversation

griffio
Copy link
Contributor

@griffio griffio commented Dec 18, 2023

👻 Add missing sequence support useful in migrations
ALTER SEQUENCE
DROP SEQUENCE

Add test fixtures 🔨

@griffio griffio force-pushed the add-postgresql-alter-drop-sequence branch from d8b598c to c5b3b27 Compare December 18, 2023 13:32
@griffio griffio marked this pull request as ready for review December 20, 2023 20:07
@AlecKazakova AlecKazakova enabled auto-merge (squash) January 29, 2024 14:02
auto-merge was automatically disabled January 29, 2024 16:49

Head branch was pushed to by a user without write access

Add test fixtures
Add AlterSequenceMixin to handle OWNED BY table.column references
Change grammar on sequence_parameters to use pin=2
The ordering of the sequence_parameters can be changed
@griffio griffio force-pushed the add-postgresql-alter-drop-sequence branch from c106b01 to dbb2c4e Compare January 29, 2024 19:44
@griffio
Copy link
Contributor Author

griffio commented Jan 29, 2024

🤕 Same test failure as other PR after merging, not related to sequences it seems - will have a look this week

execute[alter-table-alter-column] FAILED
    j   1.s line 64:28 - No column found to alter with name c1_id
        1.s line 74:28 - No column found to alter with name c1_id

@griffio
Copy link
Contributor Author

griffio commented Jan 30, 2024

OK - Fixed - the column name didn't even exist 👻 causing the test to fail

@AlecKazakova AlecKazakova merged commit 5393632 into cashapp:master Jan 30, 2024
7 checks passed
@griffio griffio deleted the add-postgresql-alter-drop-sequence branch January 30, 2024 14:33
hfhbd pushed a commit that referenced this pull request Apr 2, 2024
* Add postgresql alter sequence and drop sequence

Add test fixtures
Add AlterSequenceMixin to handle OWNED BY table.column references

* Update PostgreSql.bnf

Change grammar on sequence_parameters to use pin=2
The ordering of the sequence_parameters can be changed

* Resolve Merge Conflicts

* FIX test column name

c1_id -> c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants