Fixes 5018 PostgreSql add Primary Key not nullable types #5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griffio
changed the title
AlecKazakova
approved these changes
Feb 13, 2024
to process rules in AlterTableAddConstraintMixin
This takes a lazyQuery as input, checks if the table constraint is a primary key, updates any matching columns to not nullable, and returns a new lazyQuery with the transformed columns. This has the effect of propagating primary key nullability constraints to the columns when altering the table.
New test for MigrationQueryTest for Postgresql - not relevant for Sqlite as can't alter table to add primary keys Add tests for compiler generation for single and compound primary keys
griffio
force-pushed
the
fix_5018_postgres_add_primary_key
branch
from
7ced7f6
to
f9c237d
Compare
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Add mixin to grammar to process rules in AlterTableAddConstraintMixin * Add AlterTableAddConstraintMixin This takes a lazyQuery as input, checks if the table constraint is a primary key, updates any matching columns to not nullable, and returns a new lazyQuery with the transformed columns. This has the effect of propagating primary key nullability constraints to the columns when altering the table. * Add migration test fixtures New test for MigrationQueryTest for Postgresql - not relevant for Sqlite as can't alter table to add primary keys Add tests for compiler generation for single and compound primary keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5018
🧑🍳 🧇 Adds a mixin to the grammar to handle nullable types when adding a
PRIMARY KEYwithALTER TABLE.PostgreSql Primary Key columns are NOT NULL
AlterTableAddConstraintMixin
This takes a lazyQuery as input, checks if the table constraint is a primary key, updates matching columns to not nullable, and returns a new lazyQuery with the transformed columns. This has the effect of propagating primary key nullability constraints to the columns when altering the table.
New
MigrationQueryTestaddedtested locally with https://github.com/griffio/sqldelight-postgres-01