Fixes 5028 PostgreSql json #5030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With JDBC, setObject...Types.OTHER can be used to bind a String to a JSON type Keep the jsonDataType as a String for reading and writing This is also useful for other types like TSVector
JSON type needs special object binding to write as a String. Read as a String as normal
Previously there were no jsonQueries integration tests even though source existed
griffio
force-pushed
the
fix-5028-postgresql-json
branch
from
df651fd
to
2e6b994
Compare
hfhbd
approved these changes
Mar 19, 2024
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Add new method bindObjectOther With JDBC, setObject...Types.OTHER can be used to bind a String to a JSON type Keep the jsonDataType as a String for reading and writing This is also useful for other types like TSVector * Add JSON enum type JSON type needs special object binding to write as a String. Read as a String as normal * Add JsonQueries integration tests Previously there were no jsonQueries integration tests even though source existed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5028
🚧 🍔 👷
With JDBC, setObject...Types.OTHER can be used to bind a String to a JSON type
Add new binding method* in JdbcDriver
Keep the
jsonDataTypeas a String for reading and writingAdd JSON type for setObject...Types.OTHER binding to write as a String. Read a result String as normal
Add Docker Integration tests (none were being run for json with PostgresDialect)
*This may come in useful for other types like TSVector