Use process isolation for gradle workers #5068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlecKazakova
approved these changes
Mar 12, 2024
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
DVDAndroid
added a commit
to DVDAndroid/sqldelight
that referenced
this pull request
Aug 9, 2024
This reverts commit 9a889f5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4414
We found that the intermittent errors reported in the issue linked above happen when multiple
generateDatabaseInterfacetasks are run in parallel. Specifically, when reading intellij registry properties from a file, the input stream could be closed by another gradle worker running at the same time. This seems like a good use case for process isolation (https://docs.gradle.org/current/userguide/worker_api.html#creating_a_worker_daemon). Changing to process isolation solves the intermittent failures for our builds.