Add 2.0.0 jvm abi of primitive-adapters, android-driver, jdbc-driver, sqlite-driver and async extensions #5110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sqlite-driver and async extensions
hfhbd
force-pushed
the
hfhbd/abi
branch
3 times, most recently
from
f8f0314
to
1959636
Compare
hfhbd
commented
Apr 2, 2024
| @@ -63,6 +63,7 @@ public final class app/cash/sqldelight/driver/jdbc/JdbcPreparedStatement : app/c | |||
| public final fun bindInt (ILjava/lang/Integer;)V | |||
| public fun bindLong (ILjava/lang/Long;)V | |||
| public final fun bindObject (ILjava/lang/Object;)V | |||
| public final fun bindObjectOther (ILjava/lang/Object;)V | |||
There was a problem hiding this comment.
Cool. Wish this plugin did actual validation like Metalava so it was clear in your PR the rename was safe.
There was a problem hiding this comment.
Metalava is Androids api validator, isn't it? Is it also able to validate synthetic changes, like in 00ae621?
There was a problem hiding this comment.
I don't remember specifically. We taught it a lot of things. You can always suppress a change as being invalid while filing a bug to detect it as valid in future versions.
It doesn't handle multiplatform though. At least not yet.
JakeWharton
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added the current apiDump containing some non breaking changes.
I used the
2.0.0tag as base.