Add 5086 PostgreSql Right Full Join #5136
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5086
AlecKazakova/sql-psi#616 is now included in SqlDelight dependency
join_operator
inherited from sql-psi to include join rulesMaybe add integration test?
TODO
Add compiler test to check that
RIGHT
andFULL
allow same asLEFT
joins with nullable results https://github.com/cashapp/sqldelight/blob/master/sqldelight-compiler/src/test/kotlin/app/cash/sqldelight/core/queries/InterfaceGeneration.ktSee for nullabilty https://github.com/AlecKazakova/sql-psi/blob/4f9478e3f41f221d0ea59dcf8da6d53ee1c8c6f2/core/src/main/kotlin/com/alecstrong/sql/psi/core/psi/mixins/JoinClauseMixin.kt#L67