Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a SqlDriver for Androidx SQLiteDriver #5283

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add a SqlDriver for Androidx SQLiteDriver #5283

wants to merge 9 commits into from

Commits on Aug 21, 2024

  1. Add a SqlDriver for Androidx KMP SQLiteDriver

    @eygraber
    eygraber committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4c4759d View commit details
    Browse the repository at this point in the history

  2. Add api dump

    @eygraber
    eygraber committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    02c4f0c View commit details
    Browse the repository at this point in the history

  3. Use an in memory db for some JVM tests

    @eygraber
    eygraber committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    040969e View commit details
    Browse the repository at this point in the history

  4. Renamed to AndroidxSqliteDriver

    @eygraber
    eygraber committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    bfc97f9 View commit details
    Browse the repository at this point in the history

  5. Fix issue with closing statements that are evicted or replaced

    @eygraber
    eygraber committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    c9bb2bc View commit details
    Browse the repository at this point in the history

  6. Fix tests 

      - The issue was this driver executes more than the Android one because of the PRAGMA version calls
  - Solution was to increment the identifier so it doesn't clash with the previous one (using a cached query for a statement and vice versa
  - There was also a Robolectric issue with unclosed Closeables
    - I fixed that for the existing AndroidSqliteDriver tests as well
    @eygraber
    eygraber committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    064474c View commit details
    Browse the repository at this point in the history

  7. Add a native implementation

    @eygraber
    eygraber committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    bcb761b View commit details
    Browse the repository at this point in the history

  8. Bump androidxSqlite version

    @eygraber
    eygraber committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d0e8cbd View commit details
    Browse the repository at this point in the history

  9. Remove missed kmp references

    @eygraber
    eygraber committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    603c354 View commit details
    Browse the repository at this point in the history