meltTokens signs P2PK proofs
#165
Conversation
|
@gudnuf Let me know if this helps... |
|
@Egge21M can you bring this in? |
| proofsToSend.map((p) => { | ||
| return { | ||
| amount: p.amount, | ||
| C: pointFromHex(p.C), | ||
| id: p.id, | ||
| secret: new TextEncoder().encode(p.secret) | ||
| }; |
There was a problem hiding this comment.
Could we refactor this into getSignedProofs?
There was a problem hiding this comment.
Just saw it's in cashu/crypto and the Proof type has a different definition:
@cashu/cashu-ts
*/
export type Proof = {
id: string;
amount: number;
secret: string;
C: string;
};vs @cashu/crypto:
export type Proof = {
C: ProjPointType<bigint>;
secret: Uint8Array;
amount: number;
id: string;
witness?: Witness;
};☠️
There was a problem hiding this comment.
Yes, thats not great. Unrelated to this PR, but we should add a utility that hides this back-and-forth between the two formats in the near future
|
@lollerfirst Thank you so much for taking this on. This does look good to me, but this branch diverges from the current development branch and a merge would add some duplicate commits under old hashes. Could you please reset this branch to 4ae5562 and rebase it? |
… privkey (lost in the rebase somehow?)
lollerfirst
force-pushed
the
melt-sign
branch
from
d5ec286 to
f31f0ca
Compare
|
@Egge21M Is this good? |
Fixes: #164
Description
added option to sign P2PK proofs if a private key is provided
PR Tasks
npm run test--> no failing unit testsnpm run format