Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: Enforce explicit type annotations on function parameters #175

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

Egge21M
Copy link
Collaborator

@Egge21M Egge21M commented Sep 6, 2024

Description

This PR adds some rules to eslint that will then enforce explicit type annotation on function parameters (including arrow functions). This makes the library source code a bit more verbose, but helps with readability.

Changes

  • Add linter rules
  • Adjust code to make the linter happy

PR Tasks

  • Open PR
  • run npm run test --> no failing unit tests
  • run npm run format

@Egge21M Egge21M changed the base branch from main to development September 6, 2024 12:59
Copy link
Contributor

@callebtc callebtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Collaborator

@gandlafbtc gandlafbtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gandlafbtc gandlafbtc merged commit c6d2174 into development Sep 19, 2024
4 checks passed
@gandlafbtc gandlafbtc deleted the linter branch September 19, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants