Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pipeline to build RC from staging branch #180

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

gandlafbtc
Copy link
Collaborator

Fixes: Adding pipeline to automatically create RC from staging branch

Changes

  • Add GH action

PR Tasks

  • Open PR
  • run npm run test --> no failing unit tests
  • run npm run format

@callebtc
Copy link
Contributor

Good work, I know too little about NPM to give a good judgement here though :)

@Egge21M
Copy link
Collaborator

Egge21M commented Sep 27, 2024

@gandlafbtc great addition! Could you explain the flow for future prereleases?

We would increment the minor version number on development and then merge to staging? We would still have to add a tag ourselves, right?

I wonder if it wouldn't be better if we had version specific branches. That way we could we could work on separate versions at the same time (e.g. current release and version 2.x).

@gandlafbtc
Copy link
Collaborator Author

It would automatically create the incremented minor version and create an RC release under the next npm tag. I have git tags turned off, but maybe it's better to turn it on, so it's easier to reference?

I'm open to the idea of version branches, I haven't had too much experience with it though. So you would have to take the lead to structure that @Egge21M

@Egge21M
Copy link
Collaborator

Egge21M commented Sep 28, 2024

It would automatically create the incremented minor version and create an RC release under the next npm tag. I have git tags turned off, but maybe it's better to turn it on, so it's easier to reference?

Awesome! I was not aware that version prerelease would automatically bump to the next minor version. I think having automatic git tags could be very helpful. Ideally we would come up with a system where a merge to a branch kicks of the whole release, and tags are part of that IMO.

I'm open to the idea of version branches, I haven't had too much experience with it though. So you would have to take the lead to structure that @Egge21M

Happy to do that. Lets get this one merge first, and discuss the best way forward in a different PR. I have put this on my list and will propose something next week.

@Egge21M Egge21M changed the base branch from main to development October 19, 2024 17:48
@Egge21M Egge21M merged commit 7348cb0 into development Oct 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants