Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUT-18: Payment requests #183

Merged
merged 18 commits into from
Oct 19, 2024
Merged

NUT-18: Payment requests #183

merged 18 commits into from
Oct 19, 2024

Conversation

Egge21M
Copy link
Collaborator

@Egge21M Egge21M commented Oct 7, 2024

Fixes: none

Description

This PR adds support for en- and decoding Cashu Payment requests. It is marked as WIP as the payment request specifications are not done yet.

Changes

  • Added new Payment Request class
  • Added methods to de/encode PRs

PR Tasks

  • Open PR
  • run npm run test --> no failing unit tests
  • run npm run format

@callebtc callebtc changed the title WIP: Add support for Cashu PR en/decoding NUT-18: Payment requests Oct 19, 2024
@callebtc callebtc marked this pull request as ready for review October 19, 2024 10:32
Copy link
Collaborator

@gudnuf gudnuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@callebtc callebtc merged commit c35a992 into development Oct 19, 2024
4 checks passed
@callebtc callebtc deleted the payment_requests branch October 19, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants