-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added mint_icon_url to mint details. #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thank you for this just a small note on the SQL migration. Don't worry about the fmt ci failure it doesn't error for me locally and I don't see an issue if it keeps erroring ill investigate it.
@@ -8,6 +8,7 @@ CREATE TABLE IF NOT EXISTS mint ( | |||
description_long TEXT, | |||
contact TEXT, | |||
nuts TEXT, | |||
mint_icon_url TEXT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mint_icon_url TEXT, |
Since we want existing wallets to be able to upgrade to the new db scheme we don't want to change the init migration. Instead we need to create a new migration with the sqlx cli from within the wallet folder.
sqlx migrate add mint_icon_url
This will crate a new blank migration file where we can add the migration sql similar to the input_fee one.
ALTER TABLE mint ADD mint_icon_url TEXT;
We don't need to worry about migrating the redb database as its a new optional field it will simply be None
. The migrations are a bit weird so let me know if you have any questions or would prefer me to push a commit for it.
closes #258 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 57b110b
No description provided.