Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mint_icon_url to mint details. #282

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

cjbeery24
Copy link
Contributor

No description provided.

Copy link
Collaborator

@thesimplekid thesimplekid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thank you for this just a small note on the SQL migration. Don't worry about the fmt ci failure it doesn't error for me locally and I don't see an issue if it keeps erroring ill investigate it.

@@ -8,6 +8,7 @@ CREATE TABLE IF NOT EXISTS mint (
description_long TEXT,
contact TEXT,
nuts TEXT,
mint_icon_url TEXT,
Copy link
Collaborator

@thesimplekid thesimplekid Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mint_icon_url TEXT,

Since we want existing wallets to be able to upgrade to the new db scheme we don't want to change the init migration. Instead we need to create a new migration with the sqlx cli from within the wallet folder.

sqlx migrate add mint_icon_url

This will crate a new blank migration file where we can add the migration sql similar to the input_fee one.

ALTER TABLE mint ADD mint_icon_url TEXT;

We don't need to worry about migrating the redb database as its a new optional field it will simply be None. The migrations are a bit weird so let me know if you have any questions or would prefer me to push a commit for it.

@thesimplekid
Copy link
Collaborator

closes #258

Copy link
Collaborator

@thesimplekid thesimplekid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 57b110b

@thesimplekid thesimplekid merged commit da1acc4 into cashubtc:main Aug 10, 2024
22 of 24 checks passed
@cjbeery24 cjbeery24 deleted the feature/mint-icon-url branch August 12, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants