CLI decode-token
: use CBOR diagnostic format instead of pure JSON
#334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
decode-token
printed the pure JSON representation of a token. For V3 that is straightforward, but for V4 tokens the byte array fields were printed as arrays of numbers (decimal representation of each byte value).Example output before PR
NUT-00 defines1 how a TokenV4 JSON should look like. That is essentially the Diagnostic Notation described2 in the CBOR spec. There, byte array fields are represented like
h'00ad268c4d1f5826'
, which is anh
followed by the hex representation wrapped in single quotes.This PR updates
decode-token
incdk-cli
to print the diagnostic notation instead of the pure JSON representation of a token. This brings decoded TokenV4s in line with the format described in NUT-00, especially around how byte array fields should be handled.Example output after PR
Footnotes
https://github.com/cashubtc/nuts/blob/main/00.md#example-1 ↩
https://www.rfc-editor.org/rfc/rfc8949.html#name-diagnostic-notation ↩