NUT-04 Mint Quote Description

[lollerfirst]

No description provided.

[thesimplekid]

Thanks left a few comments.

[prusnak]

Maybe we could return here the following depending on whether the backend supports descriptions?

quote_description: ln.get_settings().invoice_description

Of course, we would need to get the value here, the code above is just a pseudo-code.

[thesimplekid]

We won't be able to do that here in default() so I think the default should be false and then here when setting MintMethofSettings for each backend in mintd we shouldn't use the default but actually set it based on what the backend supports.

[lollerfirst]

Shouldn't the default be true as this is the case for the vast majority of backends?

[thesimplekid]

I think false since even if a backend can support it the mint operator may not want to and it should be explicitly enabled.

[prusnak]

should we maybe try to pass description here if it is supported by the mint?

[thesimplekid]

Sorry about the conflicts. If you rebase onto main it shouldn't be too bad all the ones with conflicts should just be deleted except crates/cdk-integration-tests/tests/mint.rs and I think that should just be as is on main

[prusnak]

these two changes need to be applied to fix failures in the CI:

diff --git a/bindings/cdk-js/src/wallet.rs b/bindings/cdk-js/src/wallet.rs
index 3c91f71..5b65556 100644
--- a/bindings/cdk-js/src/wallet.rs
+++ b/bindings/cdk-js/src/wallet.rs
@@ -89,7 +89,7 @@ impl JsWallet {
     pub async fn mint_quote(&mut self, amount: u64) -> Result<JsMintQuote> {
         let quote = self
             .inner
-            .mint_quote(amount.into())
+            .mint_quote(amount.into(), None)
             .await
             .map_err(into_err)?;
 
diff --git a/crates/cdk-cli/src/sub_commands/mint.rs b/crates/cdk-cli/src/sub_commands/mint.rs
index ac87ec1..46ce6a2 100644
--- a/crates/cdk-cli/src/sub_commands/mint.rs
+++ b/crates/cdk-cli/src/sub_commands/mint.rs
@@ -11,9 +11,10 @@ use cdk::wallet::multi_mint_wallet::WalletKey;
 use cdk::wallet::{MultiMintWallet, Wallet};
 use cdk::Amount;
 use clap::Args;
+use serde::{Deserialize, Serialize};
 use tokio::time::sleep;
 
-#[derive(Args)]
+#[derive(Args, Serialize, Deserialize)]
 pub struct MintSubCommand {
     /// Mint url
     mint_url: MintUrl,

[lollerfirst]

@prusnak Don't we want the JS binding also use the description?

[prusnak]

@prusnak Don't we want the JS binding also use the description?

Ah yes, of course we do :-)

[prusnak]

I think we can also remove (now unused) MintMeltSettings from crates/cdk/src/cdk_lightning/mod.rs

Is that right @thesimplekid?

[thesimplekid]

I think we can also remove (now unused) MintMeltSettings from crates/cdk/src/cdk_lightning/mod.rs

Yes, don't believe there is any need for it now.

[prusnak]

LGTM f4a0652

[thesimplekid]

ACK f4a0652

LGTM. Thanks for this