Bolt12 with support for multiple payments per mint quote #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesimplekid
force-pushed
the
multiple_bolt12
branch
from
a18bf73
to
962e614
Compare
thesimplekid
force-pushed
the
multiple_bolt12
branch
5 times, most recently
from
8717405
to
3f494bc
Compare
thesimplekid
changed the title
Closed
thesimplekid
force-pushed
the
multiple_bolt12
branch
2 times, most recently
from
e24f081
to
b8198aa
Compare
feat: mint builder
thesimplekid
force-pushed
the
multiple_bolt12
branch
from
fe810db
to
6410d2b
Compare
thesimplekid
force-pushed
the
multiple_bolt12
branch
from
91fb99b
to
b056e86
Compare
thesimplekid
force-pushed
the
multiple_bolt12
branch
from
e90dc6d
to
fa2fb58
Compare
mubarak23
reviewed
Nov 20, 2024
thesimplekid
commented
Nov 21, 2024
crates/cdk-cli/src/main.rs
Outdated
| @@ -77,7 +79,7 @@ enum Commands { | |||
| #[tokio::main] | |||
| async fn main() -> Result<()> { | |||
| let args: Cli = Cli::parse(); | |||
| let default_filter = args.log_level; | |||
| let default_filter = "warn"; | |||
There was a problem hiding this comment.
set back to arg
| use cdk::wallet::multi_mint_wallet::{MultiMintWallet, WalletKey}; | ||
| use cdk::Bolt11Invoice; | ||
| // use cdk::Bolt11Invoice; |
There was a problem hiding this comment.
Suggested change
| // use cdk::Bolt11Invoice; |
crates/cdk/src/nuts/nut04.rs
Outdated
Comment on lines
98
to
101
| /// Amount that has been paid | ||
| pub amount_paid: Amount, | ||
| /// Amount that has been issued | ||
| pub amount_issued: Amount, |
There was a problem hiding this comment.
Move these to bolt12 specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR included bolt12 support for both the mint and the wallet. It also includes a large refactor of mintd, these really should have been separated but too late now (sorry).
* With use of LNDK as lnd does not directly support bolt12
** PHD doesnt allow creation of one time use bolt12, so receive cannot be supported
*** Strike api doesn't seem to support bolt12, coming soon?
Related Issues should be closed by this PR