-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brew-cask: move to using tap cmd directory. #15381
Conversation
Probably want to update |
I was thinking the same 👍 |
One question about @xu-cheng's suggestion: what about existing installations which symlink to the |
Also, the failing test is due to the |
The symlink will be removed. The only residual file will be an empty |
@jawshooah Yeh, will fix up the CI and do more testing. |
I should probably mention I’ve already seen this as well. I like the idea and have nothing to add. I’ll ask that you please always @mention @jawshooah in these situations as well, since he’s taking care of most of the actual implementation and revisions to the core. |
Don't have much to comment beyond to say the idea here is great 👍. |
Sure thing @vitorgalvao, thanks. I just mentioned you in this case as you commented on the Homebrew issue that provoked this. |
This is green now. The only outstanding issue I noticed from the formula is how we want to handle the manpage. CC @xu-cheng for ideas. |
Can one of the Homebrew Cask maintainers let me know what needs to be changed (except the |
LGTM. Not sure how manpages are usually done for external brew commands, but we can open a separate issue for that. @vitorgalvao, any objections to merging this now? |
No objections at all. I was also waiting on the mentioned manpage ideas, but I agree that can be a different issue. |
With this merged, the version number will no longer be relevant. We'll need to bump it once to prompt users to upgrade, but after that it will have no further use. How do you want to handle that? |
Ah, yes, hadn’t start thinking about that transition yet. Any suggestions? |
We can get rid of releasing.md and the bump_version, generate_changelog, and get_release_tag developer scripts, as they won't be needed anymore. Our final release notes should emphasize this change, and that there will be no more releases in the future. |
The no more releases is independent from Cask DSL changes, correct? Because PRs like #15643 (any any other additional features) will still require a bump in the cask versioning. |
@adidalal DSL versioning is completely independent from Cask's own version. |
It's important to note, however, that we aren't currently performing any meaningful validation of the DSL version. I started working on it a while ago, but haven't gotten around to finishing up. |
About manpage, a possible workaround is to auto install it whenever invoking About version, you may want to create a develop branch for core code development. |
I'll remove these.
@xu-cheng as this case seems relatively common I think I'll add an optional |
Opened a Homebrew PR for linking manpages in Homebrew/legacy-homebrew#46795. |
@jawshooah I think I've done everything you suggested and made sure |
module Hbc | ||
def self.full_version | ||
@full_version ||= begin | ||
revision, commit = Hbc.default_tappath.cd do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have Homebrew's Pathname
extensions, so this line breaks the build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, worked for me locally because this is loaded in the same process as Homebrew. I'll fix it up regardless.
@jawshooah Comments addressed (and I only just "got" your username) |
@vitorgalvao Thanks for the kind words, great project and @jawshooah thanks for the merge! |
Seeing some issues locally:
|
Might be resolved by f2c2f85. Double checking now. |
👍. Got the manpage link failure still but otherwise all issues resolved. Probably fairly unlikely anyone who wasn't watching this issue tried to update in the last 7 minutes, heh. |
👍 |
Update USAGE.md to remove brew-cask install #15381
brew-cask is no longer available since Homebrew/homebrew-cask#15381.
…ure of brew-cask - Old github.com links were invalid - Old Cellar structure was invalid - Man page regenerated, including content from Homebrew#15643 Refs Homebrew#15381
@MikeMcQuaid this is awesome! 👏 Merry christmas to us all! 🎅 |
不错的想法! 虽然我不怎么懂吧 |
@naffan2014 English only, please. Google Translate returns “Good idea! Although I do not understand it”. In essence, |
lol. google is great . it translate exactly what i mean .haha |
so i tried this today, but I am getting error:
|
@hovancik and others: Please make a new issue so we can avoid adding unrelated comments to this (merged) PR. As a pre-emptive solution, please try: brew update; brew cleanup; brew cask cleanup
brew uninstall --force brew-cask; brew update If you are still having problems, open an issue with the appropriate template |
This provides a few benefits:
brew cask
execution times as another Ruby process is not needed. Cask can instead be loaded in-process with Homebrew. This will also make it easier to use some of Homebrew's core code and ease moving code from Cask into Homebrew core.brew upgrade
Cask any more: it's done automatically on anybrew update
orgit pull
of the Cask tap.I appreciate this PR will probably not be merged as-is while we work out how to handle e.g. the Formula and I answer other questions.
CC @vitorgalvao @DomT4 @xu-cheng