-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imageoptim: Only link ImageOptim.app #259
Conversation
Before: $ brew cask install imageoptim ==> Downloading http://imageoptim.com/ImageOptim.tbz2 ######################################################################## 100.0% ==> Success! imageoptim installed to /opt/homebrew-cask/Caskroom/imageoptim/1.4.0 ==> Linking ImageOptim.app to /Users/Mathias/Applications/ImageOptim.app ==> Linking finish_installation.app to /Users/Mathias/Applications/finish_installation.app After: $ brew cask install imageoptim ==> Downloading http://imageoptim.com/ImageOptim.tbz2 ######################################################################## 100.0% ==> Success! imageoptim installed to /opt/homebrew-cask/Caskroom/imageoptim/1.4.0 ==> Linking ImageOptim.app to /Users/Mathias/Applications/ImageOptim.app
Perhaps it would be a good idea to only accept cask formulae that have an explicit |
This is a good general policy question that it'd be good to get consensus on amongst the maintainers. If you look at #257 you'll see a suggested improvement to the automatic linking code path. And if you see the #251 they decided to remove a I find myself leaning more towards your side, which would be to actually remove the automatic "link everything we find" code path and go more towards explicit linking everywhere. (If we required this to pass auditing, we'd need to provide the ability to opt out with something like a @vitorgalvao, @passcod - you want to weigh in? |
Agreed with @phinze — explicitly whitelisting everything that should be linked seems like the best/safest approach. |
I very much like the simplicity of casks, so adding (making a requirement of) the tiniest change is something I’m wary of, as every addition makes the next one easier to accept, and soon it can start to become complex for new users. However, I also believe consistency is important, and when a new user copies a cask to serve as the base to add a new one, depending on the one they copy (as it is currently) they can either add a link that is not required, or not realise that option exists, in a case that would benefit from it. For this reason alone, I think it’d be a good idea to make it a requirement (and it’s not that much extra work). On the other hand, In the end, I’d say I’m probably more inclined towards making it a requirement — consistency is important, and it may solve some unforeseen future issues with just linking everything by default. |
Do we have any, and is there any use-case for, casks that don't have executable
Now, I hope you haven't actually read all that, that would be dreadful, I'm sure I've made a fool of myself quite a few times and that a lot of it was unnecessary. You'll notice I'm still pressing the "Comment" button without deleting it all, that's how utterly hopeless I am. Have a good night. |
Well, I for one, am convinced. That was a delightful rant, @passcod, made me laugh, and I agree. It seems we have a consensus, then, that was easy. @phinze, do you want to add anything, or may I start updating casks? On another note, I’ll go right ahead and merge this one — it’s still a necessary change, whether |
imageoptim: Only link ImageOptim.app
\o/ Awesome thread is awesome. |
LOL - I have nothing to add after @passcod stole the show. ;) Let's go for it. 👍 |
I will update the apps I have submitted. |
How are we going to enforce this, via audit? |
Yeah that's what I was thinking. If we add it to audit - the build will On Sun, May 5, 2013 at 1:00 PM, Vince Cima notifications@github.com wrote:
|
Mmm, yes. This feels a bit wrong, but how about a, err, link :installer, 'SomeInstaller.pkg' or, in some cases, link :installer, 'SomeInstaller.app' which would generate a "You need to run /opt/.../caskroom/.../SomeInstaller.app manually to finish this installation." ? |
…dled remove `intellij-idea-ultimate-eap-jdk-bundled.rb`
Before:
After: