Skip to content

Commit

Permalink
Comment to make clear how class inheritance works on pipeline hooks
Browse files Browse the repository at this point in the history
  • Loading branch information
Caspar van Leeuwen committed Sep 4, 2024
1 parent 56d457b commit 24a0256
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion eessi/testsuite/eessi_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@
from eessi.testsuite import hooks
from eessi.testsuite.constants import DEVICE_TYPES, CPU, GPU, SCALES, COMPUTE_UNIT


# Hooks from the Mixin class seem to be executed _before_ those of the child class
# Thus, if the Mixin class needs self.X to be defined in after setup, the child class would have to define it before setup
# That's a disadvantage and might not always be possible - let's see how far we get
# It also seems that, like normal inheritance, functions with the same in the child and parent class will mean the child class
# will overwrite that of the parent class. That is a plus, as we can use the EESSI_Mixin class as a basis, but still overwrite
# specific functions in case specific tests would require this
class EESSI_Mixin(RegressionMixin):
"""
All EESSI tests should derive from this mixin class unless they have a very good reason not to.
Expand Down

0 comments on commit 24a0256

Please sign in to comment.