Skip to content

Commit

Permalink
Make sure that we set 'memory' as resource in all configs. This needs…
Browse files Browse the repository at this point in the history
… to be specified in order for memory to be requested by the hook
  • Loading branch information
Caspar van Leeuwen committed Sep 17, 2024
1 parent 7354fcd commit 3bc0b31
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 0 deletions.
6 changes: 6 additions & 0 deletions config/aws_mc.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,12 @@
# steps inherit environment. It doesn't hurt to define this even if srun is not used
'export SLURM_EXPORT_ENV=ALL'
],
'resources': [
{
'name': 'memory',
'options': ['--mem={size}'],
}
],
'extras': {
# Node types have somewhat varying amounts of memory, but we'll make it easy on ourselves
# All should _at least_ have this amount (30GB * 1E9 / (1024*1024) = 28610 MiB)
Expand Down
6 changes: 6 additions & 0 deletions config/azure_mc.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,12 @@
'features': [
FEATURES['CPU']
] + list(SCALES.keys()),
'resources': [
{
'name': 'memory',
'options': ['--mem={size}'],
}
],
}
for system in site_configuration['systems']:
for partition in system['partitions']:
Expand Down
6 changes: 6 additions & 0 deletions config/it4i_karolina.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@
'features': [
FEATURES[CPU],
] + list(SCALES.keys()),
'resources': [
{
'name': 'memory',
'options': ['--mem={size}'],
}
],
'extras': {
# Make sure to round down, otherwise a job might ask for more mem than is available
# per node
Expand Down
10 changes: 10 additions & 0 deletions config/settings_example.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@
'options': ['--mem={size}'],
}
],
'extras': {
# Make sure to round down, otherwise a job might ask for more mem than is available
# per node
'mem_per_node': 229376 # in MiB
},
# list(SCALES.keys()) adds all the scales from eessi.testsuite.constants as valid for thi partition
# Can be modified if not all scales can run on this partition, see e.g. the surf_snellius.py config
'features': [FEATURES[CPU]] + list(SCALES.keys()),
Expand Down Expand Up @@ -87,6 +92,11 @@
'options': ['--mem={size}'],
}
],
'extras': {
# Make sure to round down, otherwise a job might ask for more mem than is available
# per node
'mem_per_node': 229376 # in MiB
},
'devices': [
{
'type': DEVICE_TYPES[GPU],
Expand Down

0 comments on commit 3bc0b31

Please sign in to comment.