Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libp2p to 0.34.0 #819

Conversation

mpapierski
Copy link
Collaborator

This fixes security advisory on libp2p-deflate. See libp2p/rust-libp2p#1932. Quite a lot of changes

WIP clippy issues

warning: large size difference between variants
   --> node/src/reactor/joiner.rs:133:5
    |
133 |     BlockValidator(#[serde(skip_serializing)] block_validator::Event<BlockHeader, NodeId>),
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this variant is 600 bytes
    |
    = note: `#[warn(clippy::large_enum_variant)]` on by default
note: and the second-largest variant is 336 bytes:
   --> node/src/reactor/joiner.rs:85:5
    |
85  |     SmallNetwork(small_network::Event<Message>),
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
help: consider boxing the large fields to reduce the total size of the enum
    |
133 |     BlockValidator(#[serde(skip_serializing)] Box<block_validator::Event<BlockHeader, NodeId>>),
    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

^C  Building [=======================> ] 883/891: casper-node, casper-node

This fixes security advisory on libp2p-deflate.
@Fraser999
Copy link
Contributor

Fraser999 commented Jan 28, 2021

Closed in favour of #820 which builds upon this.

@Fraser999 Fraser999 closed this Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants