Add missing node os.release() implementation (denoland/deno#4065)

caspervonb · Jan 31, 2021 · 7811b11 · 7811b11
1 parent 670772d
commit 7811b11
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/node/os.ts b/node/os.ts
@@ -161,9 +161,9 @@ export function platform(): string {
   return process.platform;
 }
 
-/** Not yet implemented */
+/** Returns the operating system as a string */
 export function release(): string {
-  notImplemented(SEE_GITHUB_ISSUE);
+  return Deno.osRelease();
 }
 
 /** Not yet implemented */

diff --git a/node/os_test.ts b/node/os_test.ts
@@ -30,6 +30,13 @@ test({
   }
 });
 
+test({
+  name: "release is a string",
+  fn() {
+    assertEquals(typeof os.release(), "string");
+  }
+});
+
 test({
   name: "getPriority(): PID must be a 32 bit integer",
   fn() {
@@ -216,13 +223,6 @@ test({
       Error,
       "Not implemented"
     );
-    assertThrows(
-      () => {
-        os.release();
-      },
-      Error,
-      "Not implemented"
-    );
     assertThrows(
       () => {
         os.setPriority(0);