This repository has been archived by the owner on Apr 2, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement downloads #201
base: main
Are you sure you want to change the base?
Implement downloads #201
Changes from 5 commits
645a844
63f5f75
d1032d9
70fc006
0b9ba67
6d06bd3
c266dd0
8c6eece
efee568
8f8607f
9c770a2
144cede
b777d07
43d95d9
37a5c55
55ec83f
ea467c9
8790da9
5cadfc7
b60300b
a918ec7
d6d6b1e
9694abb
c98e482
3cbf1e9
09b6e4c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I typically avoid the extra indentation level and just namespace the class itself, i.e.
Ephemeral.DownloadsButton
. I think I'd like to do that here as well for consistency with the rest of the codebase.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I differed for the sake of two helper classes, but I can make that adjustment.