Skip to content
This repository has been archived by the owner on Apr 2, 2022. It is now read-only.

Open from clipboard #277

Merged
merged 4 commits into from
Mar 15, 2021
Merged

Conversation

meisenzahl
Copy link
Contributor

Sometimes I copy a link to the clipboard because it is not recognized as a link in the application. This pull request adds the action to open a link from the clipboard.

Screen.record.from.2021-03-10.20.17.06.mp4

Copy link
Owner

@cassidyjames cassidyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few copy/naming nits but otherwise this looks good.

data/launcher.desktop.in Outdated Show resolved Hide resolved
data/launcher.desktop.in Outdated Show resolved Hide resolved
data/launcher.desktop.in Outdated Show resolved Hide resolved
src/Application.vala Outdated Show resolved Hide resolved
Co-authored-by: Cassidy James Blaede <cassidy@elementary.io>
@cassidyjames cassidyjames merged commit b82c975 into cassidyjames:main Mar 15, 2021
@cassidyjames
Copy link
Owner

Thanks!

cassidyjames added a commit that referenced this pull request Mar 25, 2021
@cassidyjames
Copy link
Owner

@meisenzahl I had to revert this for now as it seemed to break opening links at all, and I didn't review it closely enough to understand why. 😅 I am still open to this feature, but I have to test it more thoroughly.

@meisenzahl
Copy link
Contributor Author

I'm really sorry for breaking the previous behavior.

Note that this flag only affects the default implementation of local_command_line, and has no effect if g_application_handles_command_line is given.

https://valadoc.org/gio-2.0/GLib.ApplicationFlags.HANDLES_OPEN.html

I will try to fix this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants