Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not request unused cpu resources #426

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jfcoz
Copy link

@jfcoz jfcoz commented Apr 9, 2024

do not request unused 100m cpu resources when VPA is enabled

@jfcoz jfcoz requested a review from a team as a code owner April 9, 2024 07:30
@saumas
Copy link
Contributor

saumas commented Apr 12, 2024

@jfcoz, what's the purpose of this change? CPVPA is set up to scale only memory. There's no VPA, only CPVPA. 100m is already super low. In larger clusters the active agent replica uses about 20 millicpus when collecting deltas, but it needs a lot more when booting up and collecting the initial snapshot, so 1m might slow it down to a crawl and it will hang.

@jfcoz
Copy link
Author

jfcoz commented Apr 12, 2024

I see 1m usage on small nodes.
If everybody set 100m by default, for castai, all daemonset of all cloud providers tools by default, there is nothing left for apps.
I you don’t want to hardcode another value, at least add an option to allow to configure it.

@saumas
Copy link
Contributor

saumas commented Apr 15, 2024

@jfcoz, could you change the PR to allow configuration of requests and limits?

Signed-off-by: Julien Francoz <julien@les-tilleuls.coop>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants