DE-6498: Add Storybook #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingerartur
force-pushed
the
fix/DE-6498-react-storybook
branch
2 times, most recently
from
de27b25 to
4d414e5
Compare
|
Okay, I fixed the Jest config, now it's really ready for review :) |
Add Storybook as a framework to develop and document UI. So far this is groundwork, once the Storybook docs are finished, `./app` folder can be deleted. * FIXES Several small fixes to some components such as `Duration` and `CurrentTime`, fixes to the UI and some improvements to the API. * FEATURES Create `PlayPauseIndicator`. Add CSS classes `.pp-ui-layers` and `.pp-ui-layer` intended to stack layers of UI on top of each other (e.g. player and its overlay). * TOOLING In Jest remove `transformIgnorePatterns` of `@castlabs/prestoplay` because it is not being transformed anyway, because it is getting mocked instead.
fingerartur
force-pushed
the
fix/DE-6498-react-storybook
branch
from
4d414e5 to
c4bd691
Compare
doubeka
requested changes
Oct 5, 2023
There was a problem hiding this comment.
This is such an great improvement of this documentation on these components, great job 💯
I left few comments, mostly related to docs.
Some additional extended descriptions for components in stories, when it makes (IMO) sense, some of the others may need another pass later and update even examples. (like spacer).
I also checked the followup ticket, and I am happy to help and do some work on some following updates and improvements on various components APIs. I would propose to schedule some planning session to flesh that plan furter.
| @@ -35,3 +35,6 @@ npm run publish | |||
| npm run test | |||
| ``` | |||
|
|
|||
| ## Docs | |||
Co-authored-by: doubeka <doubek.a@gmail.com>
Co-authored-by: doubeka <doubek.a@gmail.com>
Co-authored-by: doubeka <doubek.a@gmail.com>
Co-authored-by: doubeka <doubek.a@gmail.com>
Co-authored-by: doubeka <doubek.a@gmail.com>
Co-authored-by: doubeka <doubek.a@gmail.com>
Co-authored-by: doubeka <doubek.a@gmail.com>
Co-authored-by: doubeka <doubek.a@gmail.com>
Co-authored-by: doubeka <doubek.a@gmail.com>
Co-authored-by: doubeka <doubek.a@gmail.com>
|
Thanks! |
doubeka
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Added storybook for API docs and development of the components.
Here I also did a few drive-by fixes of some bugs and the API, but more will come in DE-6506. There I will also fix the rest of the stories, bc. some of them currently do not work.