Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLog + log4net NetStandard Support #340

Merged
merged 2 commits into from
Apr 20, 2018
Merged

NLog + log4net NetStandard Support #340

merged 2 commits into from
Apr 20, 2018

Conversation

snakefoot
Copy link
Contributor

Resolves #200 + Resolves #201

This was referenced Apr 2, 2018
Closed
Closed
jonorossi
jonorossi requested changes Apr 19, 2018
View reviewed changes
Copy link
Member

@jonorossi jonorossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the changes, apologies for the delay. Could you fix the review comment and add an enhancement to our release notes file in the root of the repo.

src/Castle.Services.Logging.log4netIntegration/ExtendedLog4netFactory.cs Outdated
public class ExtendedLog4netFactory : AbstractExtendedLoggerFactory
{
#if NET35 || NET40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to #if FEATURE_LEGACY_REFLECTION_API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@snakefoot
Copy link
Contributor Author

@jonorossi Add an enhancement to our release notes file in the root of the repo.

Done

@jonorossi jonorossi merged commit 7cb8580 into castleproject:master Apr 20, 2018
@jonorossi
Copy link
Member

Looks great, merged!

@jonorossi jonorossi added this to the vNext milestone Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonorossi jonorossi jonorossi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@snakefoot @jonorossi