Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of InvocationHelper cache lookups #358

Merged
merged 1 commit into from
May 14, 2018
Merged

Improve performance of InvocationHelper cache lookups #358

merged 1 commit into from
May 14, 2018

Conversation

tangdf
Copy link
Contributor

@tangdf tangdf commented May 14, 2018

KeyValuePair<Key, Value> not implemented interface IEquatable<>.

@jonorossi
Copy link
Member

Thanks @tangdf, good find, that should improve the performance of that cache lookup quite a bit. If we didn't support .NET 3.5 we could have also used a tuple.

@jonorossi jonorossi changed the title Replace KeyValuePair<MethodInfo, Type> to custom struct Improve performance of InvocationHelper cache lookups May 14, 2018
@jonorossi jonorossi merged commit d848e4d into castleproject:master May 14, 2018
@jonorossi
Copy link
Member

Merged. I've updated the changelog.

@jonorossi jonorossi added this to the vNext milestone May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants