-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate ModuleScope.DefineType
#445
Deprecate ModuleScope.DefineType
#445
Conversation
@jonorossi, this might be a good occasion to try out the public API change approval. Happy to wait for your PR (#440) to go in first, then rebase this one. |
I've merged #440, you can rebase this pull request now. |
17c9102
to
6a77ae7
Compare
6a77ae7
to
002b2f7
Compare
@jonorossi, seems to work as it should:
Nice! 👍 I'll run this locally later today to see the diff tool pop up & update the public API. |
No diff tool pops up, I think that was a feature of the now obsoleted part of the library, the "approver" part. I wouldn't have wanted that anyway, however you'll see the diff with your git client. |
@jonorossi, thanks for the correction, I see now. This is working beautifully. |
I expected to see It doesn't really worry me since it is trivial but was surprising. |
On second thought, let me retract that question. A separate PR for |
@stakx I agree, a separate PR done for another release sounds like the way to go. |
This is in response to #399 (comment):
The single known reason for using
ModuleScope.DefineType
was to allow mocking libraries to create delegate proxies, the enhancements from #436 now provide a cleaner way to do that, so we can go ahead and deprecateModuleScope.DefineType
.