-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken Linux CI build on Appveyor #496
Merged
Merged
Commits on May 6, 2020
-
The new .NET CLI (`dotnet`) cannot build projects that target `net35`, because it cannot locate the required reference assemblies. Since we're planning to drop support for .NET Framework 3.5 anyway, it is not worth finding a workaround for this problem--let's just remove that target framework now. References: * dotnet/msbuild#1333
Configuration menu - View commit details
-
Copy full SHA for ff78eb4 - Browse repository at this point
Copy the full SHA ff78eb4View commit details -
Mention only currently supported targets in docs
We no longer mention .NET Framework 3.5 support in the docs, let's do likewise for Silverlight.
Configuration menu - View commit details
-
Copy full SHA for 9e72dec - Browse repository at this point
Copy the full SHA 9e72decView commit details -
There are additions to the public API for `netstandard1.x`, which is due to some `#if`s that were previously too restrictive. (`ISet<T>` is not just supported on .NET 4.x, but on anything newer than .NET 3.5.)
Configuration menu - View commit details
-
Copy full SHA for 2b606a9 - Browse repository at this point
Copy the full SHA 2b606a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 737aaa1 - Browse repository at this point
Copy the full SHA 737aaa1View commit details -
Use official reference assemblies NuGet package
Now our build no longer relies on Mono to provide reference assemblies for the .NET Framework, and we no longer need to know where they are located.
Configuration menu - View commit details
-
Copy full SHA for c5749e1 - Browse repository at this point
Copy the full SHA c5749e1View commit details -
Simplify package restore and build using
dotnet
`dotnet build` restores packages by default, so explicitly restoring packages shouldn't be necessary. Also, there's no more need to build individual projects; `dotnet` can build whole solutions.
Configuration menu - View commit details
-
Copy full SHA for e1eb726 - Browse repository at this point
Copy the full SHA e1eb726View commit details -
This lets us choose which version of Mono to use without having to install it. This is important because the version currently preinstalled on App- Veyor has a regression that breaks our build, and installing another Mono version on AppVeyor is both slow and error-prone.
Configuration menu - View commit details
-
Copy full SHA for 3051a36 - Browse repository at this point
Copy the full SHA 3051a36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6685222 - Browse repository at this point
Copy the full SHA 6685222View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.