Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make most of DynamicProxy's internals internal #505

Merged
merged 4 commits into from
Jun 8, 2020

Commits on Jun 5, 2020

  1. Remove DynamicProxy internals from public API

    This consists mostly of making `public` types in the `Castle.Dynamic-
    Proxy` namespace `internal`, however there are a few special cases
    where types are left public but some or most of their members are made
    internal, for example:
    
     * exception types (client code should be able to catch them, but not
       instantiate them)
    
     * `TypeUtil` (proxies require some of its members at runtime)
    
     * `ModuleScope` (`SaveAssembly`, `LoadAssemblyIntoCache`, and related
       members should stay public for now, unlike others that give access
       to the internal `ModuleBuilder`)
    stakx committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    67d3543 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2020

  1. Make some adjustments for Windsor

     * Windsor needs `TypeUtil.GetAllInterfaces`, so make it public again.
    
     * Windsor is currently relying on `DelegateProxyGenerator`, but there
       is now another, more public API to build delegate proxies (see PR
       castleproject#436) so that class can
       now be removed. The unit tests for it are rewritten in terms of the
       newer API to demonstrate that it is indeed a suitable replacement.
    stakx committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    66ad575 View commit details
    Browse the repository at this point in the history
  2. Update ref/ contracts

    stakx committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    c7b5a01 View commit details
    Browse the repository at this point in the history
  3. Update the changelog

    It is no longer feasible to list every single affected type or type
    member; there's simply too many. Give a coarse summary instead.
    stakx committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    02a33b6 View commit details
    Browse the repository at this point in the history