Retire ProxyGenerationException & introduce DynamicProxyException for internal faults
#528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
commented
Jun 26, 2020
jonorossi
approved these changes
Jun 29, 2020
when an unexpected type is encountered. Chances are that IL could be emitted for those, so this will be more fitting than `NotSupported- Exception`.
If it weren't for that comment, an assertion would likely do instead.
stakx
force-pushed
the
proxygenerationexception
branch
from
a7a05ea
to
44dca55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #527, this is the last of four PRs (one per exception type) towards #518.
Due to the many different situations where
ProxyGenerationwas used, this one turned out a little messier than the other PRs.Closes #518 if merged together with the preceding three PRs.