Minimize passing around of ProxyGenerationOptions
#529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonorossi
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some prototyping for #517, I noticed that
ProxyGenerationOptionsinstances get passed around a lot needlessly. This refactoring PR gets rid of all excessoptionsparameters that I could identify, and changes some remaining usages to favour constructor injection.One caveat: Some of these removals may only be temporary. DynamicProxy weaves a web of fairly tightly coupled objects during proxy type generation (generators, collectors, contributors, emitters, etc.). If you need
optionssomewhere, chances are that you'll have to pass them through a whole lot of other objects first. Yet, removing the excess now may be a good thing as it will confront us with that problem all the more in the future, and that may lead us to consider alternative solutions—e.g. refactoring towards loose coupling, simplifying the internal object graphs, makingoptionsavailable through an ambient context, etc.