Emit delegate types in same module as their associated proxy type #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in 9538390 an issue was fixed where DynamicProxy would not always put a generated invocation type in the same dynamic module as the proxy type relying on it. It appears the same issue still exists for generated delegate types. (Those are generated for class proxies when proceeding from intercepted protected methods to the target.)
Thanks to 9538390 the necessary infrastructure is already in place, and we can apply exactly the same fix for delegate types.
|
Nothing spectacular to be seen here, this simply applies a previous bug fix to another location that was overlooked back then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569. See commit messages for details.