Improve support for covariant returns (where generic types are involved) #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonorossi, I'd appreciate your input on one particular detail here. In principle, this PR is an extension of #619, whose code patterns it duplicates for the most part. After this PR, the |
jonorossi
approved these changes
Dec 29, 2022
src/Castle.Core/DynamicProxy/Generators/MethodSignatureComparer.cs
Outdated
Show resolved
Hide resolved
src/Castle.Core/DynamicProxy/Generators/MethodSignatureComparer.cs
Outdated
Show resolved
Hide resolved
src/Castle.Core/DynamicProxy/Generators/MethodSignatureComparer.cs
Outdated
Show resolved
Hide resolved
stakx
force-pushed
the
bug/covariant-returns
branch
from
6aec65a
to
33fa217
Compare
(The type name `DerivedEmptyGenericRecord` suggests that it is generic, which is not the case; `DerivedFromEmptyGenericRecord` is more accurate. For consistency, let's apply the same name change to `EmptyRecord` and its subtype.)
stakx
force-pushed
the
bug/covariant-returns
branch
2 times, most recently
from
ef923a1
to
189dd28
Compare
Performing this check for anything other than return types is basically wasted time, so moving it to `EqualReturnTypes` means it will only run when actually needed.
stakx
force-pushed
the
bug/covariant-returns
branch
from
189dd28
to
6b16135
Compare
jonorossi
reviewed
Dec 29, 2022
jonorossi
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #632.
It turns out that we only added support for non-generic covariant return types in #619; however there are two additional cases that we need to support, too:
(I'm counting those as two distinct cases due to the code structure found inside
MethodSignatureComparer.EqualSignatureTypes, which is the method that needs to be augmented.)