.NET Core support for Castle.Core

[MattGal]

Port Castle.Core to .NET Core profile

• Previously raised and known issues have been addressed
• (Outdated) Xunit tests are passing with some disabled :
• Tests which used Assembly path-based loading APIs are disabled as this is not explicitly provided in .NET Core (Can be achieved via dependency injection in ASP.NET 5-hosted apps but it doesn't seem appropriate to depend on this. Please comment if not, as I can provide implement it taking a dependency on ASP.NET 5 interfaces.
• Five DictionaryAdapterFactory tests have been marked as Skip:
  • Two depend on ICustomAttributeInfo interface that has been removed in the Core profile. I continue to investigate ways to make this work.
  • Three are failing because code like this correctly applies the prefix attribute, but fails to correctly add it to the IDictionary accessor.

        var person = factory.GetAdapter<IPersonWithPrefix>(dictionary);

        person.Name = "Craig";

        Assert.Equal("Craig", dictionary["Name"]);

• Commits have been squashed and are currently mergable with no conflicts
• Aside from the DictionaryAdapterFactory issues I am done with associated work and awaiting for guidance on how to move forward
• I am available post-merge to assist with any follow-up needs including coordinating with teams at MS, fixing issues, etcetera, for as long as this is needed. Please make sure to include @MattGal on posts so I get alerted.

Thanks everyone for your patience, I'm eager to get this right and merged.

(Edited from previous WIP state)

[uhaciogullari]

I think you had a problem with line endings.

[kkozmic]

Nice starting point @MattGal thanks for taking that on.

It looks like there is some issue with code indention that makes out quote hard to read through the changes and have a meaningful conversation about them.

[floydpink]

Adding ?w=1 as mentioned under the Whitespace section here would allow reading through all that indentation noise, @kkozmic - https://github.com/castleproject/Core/pull/92/files?w=1

But I agree that getting the same indentation settings into the editor would be a great idea.

On that note, the .editorconfig probably could be beefed up a little more to enforce some more of the project coding-style.

Great work, @MattGal ! 👏

[kkozmic]

Sounds like a pull request Hari 😉 (editorconfig)

On Fri, 26 Jun 2015 12:42 Hari Menon notifications@github.com wrote:

Adding ?w=1 as mentioned under the Whitespace section here
https://github.com/blog/967-github-secrets would allow reading through
all that indentation noise, @kkozmic https://github.com/kkozmic -
https://github.com/castleproject/Core/pull/92/files?w=1

But I agree that getting the same indentation settings into the editor
would be a great idea.

On that note, the .editorconfig
https://github.com/castleproject/Core/blob/master/.editorconfig
probably could be beefed up a little more
http://editorconfig.org/#example-file to enforce some more of the
project coding-style.

Great work, @MattGal https://github.com/MattGal ! [image: 👏]

—
Reply to this email directly or view it on GitHub
#92 (comment).

[floydpink]

@kkozmic - I shall try and get a PR in with an updated .editorconfig

@MattGal - the project's coding standards does suggest using only tabs and not spaces. It also talks about how ReSharper (if you use it) can be configured to use the Shared project settings.
Also, if you do not have it yet, do you want to try installing the EditorConfig VS Plugin and see if that helps to enforce tabs?

[jonorossi]

@MattGal that actually made it worse. Unfortunately we don't have a completely consistent repository and it looks like you've run a formatter over the whole thing which introduced heaps more whitespace changes. For now I'd just leave this PR as is with respect to my comments in #90.

[uhaciogullari]

@MattGal Just an idea: you can just exclude DictionaryAdapter folder in project.json so you wouldn't need to modify all those files.

[MattGal]

@uhaciogullari , I had thought of that, but there is a fair amount of functionality in the folder that does actually build and may end up being useful. Also, the tax is paid now :)

[richlander]

Anything left for @MattGal to do to land the PR?

[jonorossi]

I don't want to sound rude or ungrateful for the effort but there is still quite a bit of work to do. We and our users expect the same sort of level quality as the .NET Framework does, i.e. this can't just be a fire and forget port to .NET Core. If we are changing code there needs to be a reason for it, and that needs to be documented so we can continue maintaining this code as we have been for well over a decade.

From a cursory look, things to do include:

• There are now quite a few added #ifdefs that have code in .NET Core but nothing in everything else (i.e. everything else won't compile)
• Fix the TODOs that refer to the fact that the correctness needs to be verified
• Fix or document why we need some of the changes which looks like the code now doesn't do what it does on all the other platforms. Some where I assume the API or overload may not be available in .NET Core that the code just ignores parameters, passes null, or doesn't do certain checks.
• Unit tests
• Determine whether dnxcore50 is the right framework, should we be using dotnet?
• Consider using a symbol other than CORECLR for .NET Core because it really isn't specific to the CoreCLR, if anything it would be COREFX, DNX, NETCORE, ....
• Look at what DNX generates as a NuGet package and how that compares to our build scripts' output, since I assume we'll be using that from now on

[MattGal]

@jonorossi , any update on this, or other things I can do to improve the PR?

[adamralph]

As can be seen from the issue links, the three major OSS .NET mocking frameworks (Moq, NSubstitute and FakeItEasy) are all under pressure from the community to provide support for .NET core so there is a lot of interest in getting this in. All efforts are hugely appreciated.

[AmadeusW]

I'd like to help getting this done. What's left to be done from @jonorossi previous comment? And how is this PR related to the netcore branch?

[jchannon]

What's the status of this? We want to get Nancy on CoreCLR which depends on FakeItEasy which depends on this 😄

[thecodejunkie]

I'll +1 this. Like @adamralph said, it's a core (no pun intended) component for the major mocking frameworks used by .NET OSS projects

[adamralph]

So what's the status? Has this been done elsewhere?

[jonorossi]

See the linked issue, #90.