Merge pull request #635 from Jevonius/conditional/NUNIT

NUNIT_SETCULTUREATTRIBUTE and NUNIT_TIMEOUTATTRIBUTE (Remove)
castleproject · Dec 1, 2022 · f64367f · f64367f
2 parents 1c4cc01 + 1263d4a
commit f64367f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -59,5 +59,3 @@ The following conditional compilation symbols are defined for tests only under .
 * `FEATURE_CONSOLETRACELISTENER` - enables code that requires `System.Diagnostics.ConsoleTraceListener`.
 * `FEATURE_THREADABORT` - enables code that uses `Thread.Abort()`.
 * `FEATURE_WPF` - enables code that uses `PresentationCore.dll`.
-* `NUNIT_SETCULTUREATTRIBUTE` - uses `NUnit.Framework.SetCultureAttribute`.
-* `NUNIT_TIMEOUTATTRIBUTE` - uses `NUnit.Framework.TimeoutAttribute`.
diff --git a/src/Castle.Windsor.Tests/Castle.Windsor.Tests.csproj b/src/Castle.Windsor.Tests/Castle.Windsor.Tests.csproj
@@ -70,7 +70,7 @@
 	</ItemGroup>
 
 	<PropertyGroup Condition="'$(TargetFramework)'=='net462'">
-		<DefineConstants>$(DefineConstants);NUNIT_SETCULTUREATTRIBUTE;NUNIT_TIMEOUTATTRIBUTE;FEATURE_THREADABORT;FEATURE_WPF;FEATURE_CONSOLETRACELISTENER</DefineConstants>
+		<DefineConstants>$(DefineConstants);FEATURE_THREADABORT;FEATURE_WPF;FEATURE_CONSOLETRACELISTENER</DefineConstants>
 	</PropertyGroup>
 
 </Project>
diff --git a/src/Castle.Windsor.Tests/DefaultConversionManagerTestCase.cs b/src/Castle.Windsor.Tests/DefaultConversionManagerTestCase.cs
@@ -1,4 +1,4 @@
-// Copyright 2004-2011 Castle Project - http://www.castleproject.org/
+// Copyright 2004-2022 Castle Project - http://www.castleproject.org/
 // 
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -29,20 +29,17 @@ public class DefaultConversionManagerTestCase
 	{
 		private readonly DefaultConversionManager converter = new DefaultConversionManager();
 
-#if NUNIT_SETCULTUREATTRIBUTE
-		// currently not supported by SL
 		[Test]
 		[SetCulture("pl-PL")]
 		[Bug("IOC-314")]
-		public void Converting_numbers_uses_oridinal_culture()
+		public void Converting_numbers_uses_ordinal_culture()
 		{
 			Assert.AreEqual(",", Thread.CurrentThread.CurrentCulture.NumberFormat.NumberDecimalSeparator);
 
-			var result = converter.PerformConversion<Decimal>("123.456");
+			var result = converter.PerformConversion<decimal>("123.456");
 
 			Assert.AreEqual(123.456m, result);
 		}
-#endif
 
 		[Test]
 		public void PerformConversionInt()

diff --git a/src/Castle.Windsor.Tests/LazyLoadingTestCase.cs b/src/Castle.Windsor.Tests/LazyLoadingTestCase.cs
@@ -1,4 +1,4 @@
-// Copyright 2004-2011 Castle Project - http://www.castleproject.org/
+// Copyright 2004-2022 Castle Project - http://www.castleproject.org/
 // 
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -63,7 +63,6 @@ public void Component_loaded_lazily_can_have_lazy_dependencies()
 			Container.Resolve<B>();
 		}
 
-#if NUNIT_TIMEOUTATTRIBUTE
 		[Test]
 		[Timeout(2000)]
 		public void Loaders_are_thread_safe()
@@ -98,7 +97,6 @@ public void Loaders_are_thread_safe()
 			Assert.IsNull(exception);
 			Assert.AreEqual(0, count[0]);
 		}
-#endif
 
 		[Test]
 		public void Loaders_only_triggered_when_resolving()