-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster indexing for learned sparse retrieval #2080
base: master
Are you sure you want to change the base?
Conversation
Hi @thongnt99 very interesting and thanks for the PR! Can you provide a sense of the performance improvement? |
Hi @lintool , These are some comparison points I collected from our recent reproduction attempt with LSR methods.
|
@thongnt99 this is cool! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments.
src/main/java/io/anserini/collection/JsonTermWeightCollection.java
Outdated
Show resolved
Hide resolved
src/main/java/io/anserini/collection/JsonTermWeightCollection.java
Outdated
Show resolved
Hide resolved
src/main/java/io/anserini/index/generator/TermWeightDocumentGenerator.java
Outdated
Show resolved
Hide resolved
Instead of |
Yes, I also think that TermWeightDocument isn't an ideal name. Probably |
I like |
@lintool
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about some tests?
@lintool I am gonna add the tests after ECIR. |
Related to #1890
On-going work: Using FeatureField to directly index terms and weights
The indexing works and returns the same metrics as the token repeating method, but three tests (for the repeating method) are currently failing. Please let me know how to fix the tests or create new tests.
Indexing:
Retrieval: