Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AToMiC demo page to support dense search #1721

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dlrudwo1269
Copy link
Contributor

Update AToMiC demo page to support the dense searchers.

One issue is that it is difficult to navigate the image ids when searching for pre-encoded queries for images. I was thinking of adding a index->topic file mapping in the server, and in search_options() we search the topic file to get the image_urls of the matching options to pass to the client side. Did you have any other suggestions on how to better handle this @jasper-xian ?

Demo video: https://youtu.be/ukb4Bc0XzW4

@dlrudwo1269
Copy link
Contributor Author

@jasper-xian @justram would appreciate a review here!

@jasper-xian
Copy link
Member

Not sure I'm the right person to comment on this, but the way we did pre-encoded image queries was something like this:

Topics: {'id': , 'title': }
Pre-encoded queries: {'id': , 'text': , 'embedding': }

So you could use the image-id to search for the right image. I'm not sure what this mapping stuff relates to in general though, but I think the app looks good! @justram can probably comment more about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants