Use fully constructed confirmationWindow instead of testing for null

On advice, removed the null test and replaced it with an initializer. Also removed unnecessary property declaration in pom.
castorm · Dec 26, 2020 · a8751e8 · a8751e8
1 parent e4cbbd2
commit a8751e8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/kafka-connect-http/pom.xml b/kafka-connect-http/pom.xml
@@ -11,10 +11,6 @@
     <artifactId>kafka-connect-http</artifactId>
     <name>Kafka Connect HTTP</name>
 
-    <properties>
-        <env.GPG_PASSPHRASE>bogus</env.GPG_PASSPHRASE>
-    </properties>
-
     <dependencies>
         <dependency>
             <groupId>org.projectlombok</groupId>

diff --git a/kafka-connect-http/src/main/java/com/github/castorm/kafka/connect/http/HttpSourceTask.java b/kafka-connect-http/src/main/java/com/github/castorm/kafka/connect/http/HttpSourceTask.java
@@ -45,6 +45,7 @@
 import java.util.function.Function;
 
 import static com.github.castorm.kafka.connect.common.VersionUtils.getVersion;
+import static java.util.Collections.emptyList;
 import static java.util.Collections.emptyMap;
 import static java.util.Optional.ofNullable;
 import static java.util.stream.Collectors.toList;
@@ -66,7 +67,7 @@ public class HttpSourceTask extends SourceTask {
 
     private SourceRecordFilterFactory recordFilterFactory;
 
-    private ConfirmationWindow<Map<String, ?>> confirmationWindow;
+    private ConfirmationWindow<Map<String, ?>> confirmationWindow = new ConfirmationWindow<>(emptyList());
 
     @Getter
     private Offset offset;
@@ -141,8 +142,6 @@ public void commitRecord(SourceRecord record, RecordMetadata metadata) {
 
     @Override
     public void commit() {
-        if (null == confirmationWindow)
-            return;
         offset = confirmationWindow.getLowWatermarkOffset()
                 .map(Offset::of)
                 .orElse(offset);