Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for summary silently dropped #69

Closed
ximon18 opened this issue Mar 16, 2023 · 2 comments · Fixed by #70
Closed

Support for summary silently dropped #69

ximon18 opened this issue Mar 16, 2023 · 2 comments · Fixed by #70
Labels
bug Something isn't working

Comments

@ximon18
Copy link

ximon18 commented Mar 16, 2023 •
edited
Loading

The README still says:

summary: the package summary/description. If not present, package.description is used.

However, PR #46 removed support for this and was included in release v0.9.0, but no mention of this was made in the release notes and the README was not updated.

Worse, using summary doesn't cause an error or warning, it just doesn't have the desired effect.

I only found this because rpmlint complains about my description being too long even though I set summary to a shorter text.
@cat-in-136
Copy link
Owner

Oh, it is just a degrade bug caused by typo.

@cat-in-136 cat-in-136 added the bug Something isn't working label Mar 16, 2023
cat-in-136 added a commit that referenced this issue Mar 16, 2023
@cat-in-136
fix bug #69 where summary metadata ignored
dc171d3 
it is a degrade bug caused by #46
cat-in-136 added a commit that referenced this issue Mar 17, 2023
@cat-in-136
Merge pull request #70 from cat-in-136/fix-issue-69
6053eb3 
fix bug #69 where summary metadata ignored
@cat-in-136 cat-in-136 mentioned this issue Mar 17, 2023
Merged
@ximon18 ximon18 mentioned this issue Mar 20, 2023
Merged
19 tasks
@ximon18
Copy link
Author

ximon18 commented Mar 20, 2023

Thanks @cat-in-136 for the quick response!

@ximon18 ximon18 mentioned this issue Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bug #69 where summary metadata ignored cat-in-136/cargo-generate-rpm
2 participants
@cat-in-136 @ximon18