Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighting a molotov cocktail causes it to disappear #5464

Closed
Soadreqm opened this issue Sep 29, 2024 · 4 comments · Fixed by #5480
Closed

Lighting a molotov cocktail causes it to disappear #5464

Soadreqm opened this issue Sep 29, 2024 · 4 comments · Fixed by #5480
Labels
bug confirmed Bug that has been reproduced src changes related to source code.

Comments

@Soadreqm
Copy link
Contributor

Describe the bug

A lit molotov will vanish one turn after it was lit. Since lighting a molotov takes nonzero time, most times it just disappears instantly.
If you manage to light a molotov in less than one second, so that a turn does not pass, the molotov remains in inventory and can be thrown as normal.

Molotov cocktail should not vanish until after you throw it, and it should generally cause a burst of fire when it does so.

Steps To Reproduce

  1. spawn molotov
  2. apply molotov
  3. where is the molotov?

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: Windows 10 Pro N
  • Game Version: ed4d9fb [64-bit]
  • Graphics Version: Tiles
  • LAPI Version: 2
  • Game Language: []
  • Mods loaded: [
    Bright Nights [bn],
    Disable NPC Needs [no_npc_food],
    Simplified Nutrition [novitamins],
    No Rail Stations [No_Rail_Stations],
    Item Category Overhaul [Item_Category_Overhaul]
    ]

Additional context

stalin_censorship_1
Molotov is the one with the glasses, on the left. He is NOT supposed to be the one who disappears.

@Soadreqm Soadreqm added the bug label Sep 29, 2024
@RoyalFox2140 RoyalFox2140 added confirmed Bug that has been reproduced src changes related to source code. labels Sep 30, 2024
@RoyalFox2140
Copy link
Collaborator

May be related #5297

@RoyalFox2140
Copy link
Collaborator

I set initial and max charges to 5 on the molotov. It fixed nothing.

Sometimes it disappears after 5 charges are used, and sometimes I can store them on the floor, they never detonate in either case unless thrown.

@RoyalFox2140
Copy link
Collaborator

image

@RoyalFox2140
Copy link
Collaborator

RoyalFox2140 commented Sep 30, 2024

Btw molotovs quenched by rain don't stop being lit. They're still throwable. This is probably why I store lit molotovs on the floor.

DEBUG : Tried to invoke transform on a Molotov cocktail, which doesn't have this use_function

FUNCTION : int itype::invoke(player&, item&, const tripoint&, const std::string&) const
FILE : src/itype.cpp
LINE : 189
VERSION : BN 3a81ca5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed Bug that has been reproduced src changes related to source code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants