fix: Molotov Fix/Rework, make turn_per_charge less inconsistent.

[KheirFerrum]

Checklist

Required

• I wrote the PR title in conventional commit format.
• I ran the code formatter.
• I linked any relevant issues using github keyword syntax so it can be closed automatically.
• I have committed my changes to new branch that isn't main so it won't cause conflict when updating main branch later.

Purpose of change

• fixes Lighting a molotov cocktail causes it to disappear #5464 which was due to fix: Grenade rework #5297 causing this to disappear really early as it quickly hits 0 charge.
• Aims to make turns_per_charge less inconsistent by having tool items keep track of how long they've been active since last consumption.

Describe the solution

• Molotov behaviour is now changed in the following ways

  • Base molotov has no charges, instead it transforms into the lit molotov that has 1 charge.
    • Lit molotovs last 5 turns before extinguishing themselves and converting back into the uncharged molotov.
    • If a molotov is extinguished by water or rain, it will not stack with the other molotovs because internally it's considered to have 1 charge, even if its otherwise identical to the player.
  • Dropping a molotov no longer causes it to explode, and instead of exploding with no warning when you activate a lit molotov, it asks you if you really want to set yourself and the squares around you on fire.

• Tool items with turns_per_charge now keep track of how long they have been active via turns_active variable.

  • If turns_active exceeds turns_per_charge the item consumes it's per use charges and resets turns_active.
  • Modified the foodperson helmet to keep track of this as well when telling you how much time is left on your shift.

Describe alternatives you've considered

• Reworking the entire molotov iuse to make it more versatile for impact explosives.
  • I don't have time for this right now, so this will last as a stopgap measure that restores functionality until I have time to make it better than it was.

Testing

• Molotovs can be activated, and extinguish after 5 turns or if they are exposed to rain/water
  • Molotovs explode when thrown, not when dropped, not when left on the floor, and not in your inventory.
  • Activating a lit molotov asks for confirmation before exploding all over you with sticky warm goo.
• Foodperson helmet doesn't bug out when viewing shift.

Additional context

[chaosvolt]

1. Compiled and load-tested.
2. Spawned in and activated a molotov.
3. Tossed it, it go fwoosh yaaay.
4. Spawned in rags and tested to make sure that changing them to ammo doesn't screw up their use actions.
5. Crafted a molotov. It still consumes a rag as a component in the recipe, but produces a molotov with 0/1 ammo in it so you need to waste a second rag loading it.

[KheirFerrum]

1. Compiled and load-tested.
2. Spawned in and activated a molotov.
3. Tossed it, it go fwoosh yaaay.
4. Spawned in rags and tested to make sure that changing them to ammo doesn't screw up their use actions.
5. Crafted a molotov. It still consumes a rag as a component in the recipe, but produces a molotov with 0/1 ammo in it so you need to waste a second rag loading it.

Looks like setting it to use tangible ammo makes it not be created with initial charges, will remove rags from the recipe, as I don't see any way to make recipes force the initial charge.

[chaosvolt]

Specifying initial_charges in the item wouldn't work?

[KheirFerrum]

Specifying initial_charges in the item wouldn't work?

It already has it to begin with. It just doesn't apply outside of debug spawning it it seems.

[chaosvolt]

Ah right, damn. Guess that works but it feels real hacky having to load the rag manually after filling it, hmm. This is technically only mandated by it having turns_per_charge defined, right? Though I suppose without it, and combined with it no longer going off when dropped, the player could exploit an infinitely-burning molotov for light, bleh. :/

[KheirFerrum]

Ah right, damn. Guess that works but it feels real hacky having to load the rag manually after filling it, hmm. This is technically only mandated by it having turns_per_charge defined, right? Though I suppose without it, and combined with it no longer going off when dropped, the player could exploit an infinitely-burning molotov for light, bleh. :/

It's technically mandated by me making them reloadable with rags. If we went by the old behaviour, every time it went out it would refill it's charges and you could light it again.

[chaosvolt]

Fair, I was wondering whether that'd technically be okay on the basis of the rag serving as a wick, but this would technically make the fuel infinite-use instead. This would only really matter if the player repeatedly lights a molotov and lets it burn out again and again until they start questioning why it hasn't run out of fuel by then, but that'd be a bit of a wacky scenario to begin with.

[KheirFerrum]

Fair, I was wondering whether that'd technically be okay on the basis of the rag serving as a wick, but this would technically make the fuel infinite-use instead. This would only really matter if the player repeatedly lights a molotov and lets it burn out again and again until they start questioning why it hasn't run out of fuel by then, but that'd be a bit of a wacky scenario to begin with.

To be fair another way we could do it is have it never burn out and only be "extinguished" by rain and water

[RoyalFox2140]

Huh.

[chaosvolt]

I think it just burning out after a bit but being able to be re-lit without having to provide a fresh rag is probably acceptable, compared to having to manually stuff the rag in before use each time after making it. Like I said, it would only look weird if the player lights and extinguishes it multiple times, whereas the rag thing will look weird every time one's crafted.

[KheirFerrum]

I think it just burning out after a bit but being able to be re-lit without having to provide a fresh rag is probably acceptable, compared to having to manually stuff the rag in before use each time after making it. Like I said, it would only look weird if the player lights and extinguishes it multiple times, whereas the rag thing will look weird every time one's crafted.

I feel like the latter makes more sense than the former, though like... we could also just make it burn forever and have the activation effect allow you to manually extinguish it. I just feel that the behaviour where you can wait it out and relight it is very odd, and codewise looks kind of weird.

[chaosvolt]

That would work I guess too? I just find it really weird having to craft a molotov and then basically "fuze" it manually afterward. It stands out as kinda weird when every other grenade-type item in the game is crafted as an all-in-one deal.

[KheirFerrum]

That would work I guess too? I just find it really weird having to craft a molotov and then basically "fuze" it manually afterward. It stands out as kinda weird when every other grenade-type item in the game is crafted as an all-in-one deal.

Okay. I also recalled that WATER_EXTINGUISH won't proc this charge renewal, which would have been a problem for the original setup.

[scarf005]

maybe we could make molotov use oil as charge?

[KheirFerrum]

maybe we could make molotov use oil as charge?

Pretty sure it having an ammo type at all is what's causing it to spawn with no charges, so changing that won't change the problem.

[scarf005]

Pretty sure it having an ammo type at all is what's causing it to spawn with no charges, so changing that won't change the problem.

oh, i meant as a balance change.

[chaosvolt]

Oh, I see now. Fair enough in that case, we can keep that for now and add an option to manually extinguish it in a later PR then.

[chaosvolt]

These should be all the changes needed to make it do the "return to a lightable molotov if it goes out" thing, lemme know if I missed anything.

[KheirFerrum]

These should be all the changes needed to make it do the "return to a lightable molotov if it goes out" thing, lemme know if I missed anything.

There's still iuse code that needs to be done to make it revert properly when running out of charges and water_extinguish code so it actually reverts properly. This just reverts it to the prior broken state. Give me a few minutes.

[chaosvolt]

Ah, no worries then. I'm currently out and about on wifi so won't be able to compile-test the new changes until I get home, so take your time if needed. ^^

[RoyalFox2140]

So to be fair, I only tested spawning it, not crafting it. Why it spawns as 0/1 when crafted is beyond me.

[KheirFerrum]

So to be fair, I only tested spawning it, not crafting it. Why it spawns as 0/1 when crafted is beyond me.

Because it's been given an ammo type, there's no code to make it spawn with specific ammo and count, and it defaults against that in case you're making magazines and the like. Anyway, code's rewritten, updating the original PR. I'm annoyed, but hey, it works about right now

[RoyalFox2140]

I can't in good faith accept an infinite light source exploit by holding lit molotovs in my inventory indefinitely. Someone else can feel free to accept the PR if they don't see it as a big deal.

[RoyalFox2140]

God has granted us unlimited light.

[chaosvolt]

Hmm. I thought the idea was they'd burn out and revert back to an unlit molotov if you don't throw them quickly enough?

[KheirFerrum]

Hmm. I thought the idea was they'd burn out and revert back to an unlit molotov if you don't throw them quickly enough?

All three implementations have issues, some are under the hood, and some are overt.

Original (intended) implementation

• Behaviour: Item reverts after several turns, refilling it's charges to full again to allow reignition.
• Drawbacks: Code needs special handling as revert() preserves current charges, so both the iuse code and WATER_EXTINGUISH code must restore charges, and WATER_EXTINGUISH code must specifically target only items with iuse::molotov_lit or we get cigarettes that replenish themselves to full as long as you douse them in water before they are depleted.

Rag implementation

• Behaviour: Item reverts after several turns, consuming a rag to fuel it.
• Drawbacks: Recipe cannot produce molotov with charges, so players must manually reload them on craft.

New implementation

• Behaviour: Item doesn't revert unless in water or player extinguished, can essentially be toggled between both.
• Drawbacks: Infinite light source.

I don't like the first implementation because it's a lot of special case code handling for 1 specific iuse that needs to be careful about not treading on anything else's toes. And I can't just revert it to the original implementation and expect it to be fine because the original code as is doesn't revert at all when WATER_EXTINGUISH procs, invoking a non-existent transform that fails and leaves an inactive lit molotov. Adding revert means that it will revert into a molotov that has no charges. So I have to intentionally screw the code.

Putting this in draft while I think of a better stopgap that compromises between them and is acceptable to all of us.

[RoyalFox2140]

[RoyalFox2140]

I mean, It works as intended and works under our old system of being relightable forever. It's not ideal but it's what we have right now.

[chaosvolt]

Hopefully is fine then, still out and about so can't compile-test weh

[chaosvolt]

1. Compiled and load-tested.
2. Crafted a molotov.
3. Lit it, let it burn out, no odd behavior and I can re-light it without issue.
4. Lit it, tossed it, it go fwoosh. :D