-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs!: new documentation page #3121
Conversation
9832c18
to
1806337
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a brief glance:
Looks coolMuch centralized, such convenient. The search feels quite good, it's faster than GitHub and you don't get many irrelevant results you often get from the repo.- Does this support offline builds, so we could bundle prebuilt website with the releases? With no internet connection, players or modders would be able to just open the game folder, navigate to the doc folder, double click index.html and view the docs with the browser.
Offline builds like that would actually solve the version tracking problem
Should the website track different documentation for different builds/releases, and if so, then how?
...since the user would be able to simply download the needed release off GitHub and view the docs bundled with it.
- On that topic, it would be nice to have a note that is linked from the main
README.md
and explains where to find the documentation in the filesystem and how to build & run the website locally. Yes, it's explained indoc/src/content/docs/en/contributing/docs.mdx
, but you wouldn't find that file unless you chance on it, and relying on the online website isn't quite robust since the website (or the build process) may change in the future.
Regarding the website itself, some aspects could use some polish, but as I understand it comes with time.
- The 2D navigation is a bit jarring. There's a sidebar on the left with the topics, but there are also tabs with categories on the top, and sometimes clicking a topic would silently switch the category, meaning you're presented with a completely new set of topics.
- Many pages have inconsistent naming styles (lower case vs normal text vs caps) and broken ToCs on the right side.
- Some pages cover many topics, while some topics can have multiple pages. Some wiki pages, for once, just mirror existing doc pages or should be integrated into the docs or removed.
Maybe a less green color theme
As to the docs themselves, we still have many outdated docs that mention DDA, or (not) mention fields and functionality that (is no longer)/(should be) there, so some kind of warning on the website would be warranted.
doc/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be here? Looks like a leftover from some starlight template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i've edited a bit but it's still leftover from default template. i'll symlink with docs page building guide instead.
EDIT: starlight doesn't support file-based routing yet, it might take more time to bundle this, as currently the only way to read docs offline is to run a dev server.
ok, will
do you mean
do you mean filenames? i'll do it rn
could you point out where? i'll try to fix them
done.
will add. |
see: cataclysmbnteam#3121 (comment) Co-authored-by: olanti-p <olanti-p@yandex.ru>
see: cataclysmbnteam#3121 (comment) Co-authored-by: olanti-p <olanti-p@yandex.ru>
Sure. Here's all the issues I could find, including ToC problems: Broken links:
Remaining cases of inconsistent case in left sidebar:
Issues with ToC in right sidebar. These seems to have 1 thing in common: the missing headers look larger then the ones with links.
Misc feedback for individual pages:
These issues are probably not caused by this PR:
|
Co-authored-by: olanti-p <olanti-p@yandex.ru>
Co-authored-by: olanti-p <olanti-p@yandex.ru>
Co-authored-by: olanti-p <olanti-p@yandex.ru>
Co-authored-by: olanti-p <olanti-p@yandex.ru>
BN does not support homebrew
Unfortunately |
could you elaborate further? |
They're geo-blocking Russian IPs (for obvious reasons), at least, maybe other countries. |
Looks like the only docs left worth including are the contents of There are other small markdown or text files scattered here and there, but none of them seem to be worth putting on the website, as they mostly describe the workings of specific directories they belong to:
|
@olanti-p do you think this is ready for merging? |
Yes. |
Summary
https://docs.cataclysmbn.org/en/
SUMMARY: Infrastructure "Create a new documentation page for better accessibility"
Purpose of change
original reply
looks coolDescribe the solution
Testing
original questions
Describe alternatives you've considered
#3062 may handle documentations better than this, but it wouldn't hurt to have a quick docs page running.
Additional context
after the merge only the URL (cataclysm.org) redirect needs to be done