perf: cache character's dead state #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see: CleverRaven/Cataclysm-DDA@5c5b7ca Co-authored-by: Andrew Krieger <akrieger@users.noreply.github.com>
chaosvolt
approved these changes
Sep 27, 2023
Merged
via the queue into
cataclysmbnteam:upload
with commit Sep 27, 2023
8aa0a1b
9 of 14 checks passed
|
...nice. |
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Sep 28, 2023
* perf: extract glass jaw to variable * perf: cache `Chracter::is_dead_state` see: CleverRaven/Cataclysm-DDA@5c5b7ca Co-authored-by: Andrew Krieger <akrieger@users.noreply.github.com> * refactor: reorganize suffer_in_sunlight * refactor: use std::any_of * style(autofix.ci): automated formatting --------- Co-authored-by: Andrew Krieger <akrieger@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Performance "Port character dead state caching from DDA"
Purpose of change
ported
Testing
Before
after
with #3283